Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request introduces a mechanism to subscribe to asynchronous error notifications within the Switcher client, particularly useful for scenarios where throttle and silent mode are enabled. It also adds tests to verify that errors are properly captured and cleared when using silent mode.
Error Notification Subscription:
subscribe_notify_errorstatic method to theClientandExecutionLoggerclasses, allowing consumers to register a callback that will be invoked when an asynchronous error occurs. This is particularly useful for handling errors in silent or throttled modes. [1] [2]_notify_errormethod in theSwitcherclass to trigger the registered error callback when exceptions are caught during remote criteria execution. [1] [2]Testing Enhancements:
test_switcher_silent_mode.pyto register an error notification callback, assert that errors are captured when remote API calls fail, and verify that errors are cleared after silent mode expires or the API is restored. [1] [2] [3] [4]